Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator Monitoring Service Milestone 2 #1155

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

avtishin
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1791

@avtishin
Copy link
Contributor Author

Not sure about the failed checks, please let me know if I need to change anything!

@keeganquigley keeganquigley self-assigned this Mar 28, 2024
@keeganquigley
Copy link
Contributor

Thanks @avtishin starting your evaluation now and I will look into it.

Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avtishin everything is working great so far and I am able to fire up the bot locally and in production. Here is my ongoing eval. I just have the two following notes:

  • I'm not finding any unit tests or e2e tests for the python logic, can you point me to these if they exist?
  • Typically we ask teams to provide a link for each milestone category, to easily find the code. I was able to find everything but would still be nice if you could add those.

Thanks!

@avtishin
Copy link
Contributor Author

avtishin commented Apr 8, 2024

Hey @keeganquigley, thanks for your evaluation and the excellent questions.

  1. Up to now, we have been using pretty standard tools like Prometheus and Grafana and standard tg libraries (which all have their own unit tests). We do not implement automatic unit tests, but we have test cases (as you can find in the telegram bot, there is a test alert that checks the operation of the alert system). We do not have a dedicated QA who can cover everything, and also I think covering everything is technically impossible. However, besides this alerting test case, what else are you looking to be covered by tests?
  2. I'll try to update the milestone delivery, but I did not initially do it because compared to the 1st milestone, all the code was re-build :D

@keeganquigley
Copy link
Contributor

Thanks @avtishin for the explanations, much appreciated. I'm happy to pass the milestone, here is the final evaluation. Congrats!

@keeganquigley keeganquigley merged commit 397e757 into w3f:master Apr 9, 2024
4 of 6 checks passed
@keeganquigley
Copy link
Contributor

Please fill out the invoice form in order to initiate the payment process. Thank you!

@keeganquigley
Copy link
Contributor

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@avtishin
Copy link
Contributor Author

avtishin commented Apr 9, 2024

@keeganquigley, thanks for your evaluation; we are happy you liked your project! As well as we will try to push it into the 1KV community because it seems the most suitable place. Also, today, we will make a PR that corrects spelling mistakes.
The invoice has been submitted

@RouvenP
Copy link

RouvenP commented Apr 12, 2024

hi @avtishin we just sent the payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants